-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Allow publish
handle files with filenames separated by spaces
#5476
base: master
Are you sure you want to change the base?
Conversation
How to testgit clone -b draft_filename https://github.com/yapinxxx/hexo.git
cd hexo
npm install
npm test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like to create a test case against your changes?
If you could assist me in creating a test case, I would greatly appreciate it. Before submitting my change, I experimented with modifications in the node_modules directory to test my idea. Once I confirmed the concept could work, I directly edited the TypeScript source code. However, I faced challenges building the project and comparing changes before and after, so I submitted the pull request without a comparison. Additionally, creating a test case proved difficult due to my limited expertise in front-end development. |
Hello @SukkaW , |
You are introducing a new behavior (correct handling of the special filename) that doesn't exist in the current version of Hexo. You will need to add a test case to make sure that Hexo will always handle the special filename properly. So in the future when we run |
7e4d138
to
5d31f02
Compare
…t_folder` is enabled (hexojs#5473)
… spaces in the _draft folder.
publish
handle files with filenames separated by spacespublish
handle files with filenames separated by spaces
Allow the publish command to handle files with filenames separated by spaces in the _draft folder.
What does it do?
The update enables filenames to include spaces in the
_draft
folder.However, the source code modifies the original filename(
data.slug
) and then incorrectly compares it with the filenames in the_draft
folder, leading to erroneous results.