Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass the language option for codeblock tag #5259

Closed
wants to merge 0 commits into from
Closed

fix: pass the language option for codeblock tag #5259

wants to merge 0 commits into from

Conversation

xihale
Copy link

@xihale xihale commented Jul 29, 2023

What does it do?

I will pass the language option when I use either of highlight.js or prism.js for codeblock tag!

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

How to test

git clone -b master https://github.com/xihale/hexo.git
cd hexo
npm install
npm test

Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding unit test cases toward your changes?

@xihale
Copy link
Author

xihale commented Jul 30, 2023

Would you mind adding unit test cases toward your changes?

but, I don't know what unit test I should add, can you help me?
Just tell me where I can find how to add unit test for hexo changes! Thanks!

Anyway, I will try it!

@xihale
Copy link
Author

xihale commented Jul 30, 2023

I added a unit test to test my changes and find a inconspicuous bug then fixed it.

@xihale xihale requested a review from SukkaW August 1, 2023 12:26
@stevenjoezhang stevenjoezhang changed the base branch from master to v7.0.0 August 1, 2023 16:48
@stevenjoezhang stevenjoezhang changed the base branch from v7.0.0 to master October 25, 2023 05:02
@uiolee uiolee added the javascript Pull requests that update Javascript code label Jan 12, 2024
@xihale xihale closed this Mar 2, 2024
Copy link

github-actions bot commented Mar 2, 2024

How to test

git clone -b master https://github.com/xihale/hexo.git
cd hexo
npm install
npm test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants