fix: figcaption only works within figure (#279)

hexojs · Apr 2, 2024 · 369db18 · 369db18
1 parent 16b1fb0
commit 369db18
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/renderer.js b/lib/renderer.js
@@ -137,8 +137,8 @@ class Renderer extends MarkedRenderer {
     if (lazyload) out += ' loading="lazy"';
 
     out += '>';
-    if (figcaption) {
-      if (text) out += `<figcaption aria-hidden="true">${text}</figcaption>`;
+    if (figcaption && text) {
+      return `<figure>${out}<figcaption aria-hidden="true">${text}</figcaption></figure>`;
     }
     return out;
   }

diff --git a/test/index.js b/test/index.js
@@ -806,8 +806,8 @@ describe('Marked renderer', () => {
 
     result.should.eql([
       '<p><img src="/bar/baz.jpg" title="bar">',
-      '<img src="/bar/baz.jpg" alt="foo" title="bar"><figcaption aria-hidden="true">foo</figcaption>',
-      '<img src="/aaa/bbb.jpg" alt="foo"><figcaption aria-hidden="true">foo</figcaption></p>\n'
+      '<figure><img src="/bar/baz.jpg" alt="foo" title="bar"><figcaption aria-hidden="true">foo</figcaption></figure>',
+      '<figure><img src="/aaa/bbb.jpg" alt="foo"><figcaption aria-hidden="true">foo</figcaption></figure></p>\n'
     ].join('\n'));
   });