Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark client retry backoff function as static #429

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

jooola
Copy link
Member

@jooola jooola commented Jul 30, 2024

Ensure the function does not receive 2 arguments (self, retries)

Ensure the function does not receives 2 arguments (self, retries)
@jooola jooola merged commit 14ed130 into main Jul 30, 2024
10 checks passed
@jooola jooola deleted the use-static-method branch July 30, 2024 17:32
jooola pushed a commit that referenced this pull request Jul 30, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.1.1](v2.1.0...v2.1.1)
(2024-07-30)


### Bug Fixes

* do not sleep before checking for the reloaded action status
([#426](#426))
([3e0a85b](3e0a85b))
* mark client retry backoff function as static
([#429](#429))
([14ed130](14ed130))


### Documentation

* add api changes note in changelog
([#424](#424))
([5cbe188](5cbe188))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (d2540d4) to head (2359a0b).
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files          64       64           
  Lines        2960     2960           
=======================================
  Hits         2756     2756           
  Misses        204      204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant