Skip to content

Commit

Permalink
feat: drop support for python 3.8 (#458)
Browse files Browse the repository at this point in the history
Python 3.8 is EOL since 07 Oct 2024.

https://devguide.python.org/versions/
  • Loading branch information
jooola authored Nov 5, 2024
1 parent aca4a8a commit e74e319
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:

strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]

name: Python ${{ matrix.python-version }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ test:

parallel:
matrix:
- python_version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
- python_version: ["3.9", "3.10", "3.11", "3.12", "3.13"]

image: python:${python_version}-alpine
before_script:
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ repos:
rev: v3.19.0
hooks:
- id: pyupgrade
args: [--py38-plus]
args: [--py39-plus]

- repo: https://github.com/pycqa/isort
rev: 5.13.2
Expand Down
4 changes: 2 additions & 2 deletions hcloud/metrics/domain.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
from __future__ import annotations

from datetime import datetime
from typing import Dict, List, Literal, Tuple
from typing import Literal

from dateutil.parser import isoparse

from ..core import BaseDomain

TimeSeries = Dict[str, Dict[Literal["values"], List[Tuple[float, str]]]]
TimeSeries = dict[str, dict[Literal["values"], list[tuple[float, str]]]]


class Metrics(BaseDomain):
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ requires = ["setuptools"]
build-backend = "setuptools.build_meta"

[tool.pylint.main]
py-version = "3.8"
py-version = "3.9"
recursive = true
jobs = 0

Expand Down
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,13 @@
"License :: OSI Approved :: MIT License",
"Natural Language :: English",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
],
python_requires=">=3.8",
python_requires=">=3.9",
install_requires=[
"python-dateutil>=2.7.5",
"requests>=2.20",
Expand Down
3 changes: 1 addition & 2 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py38, py39, py310, py311, py312, py313
envlist = py39, py310, py311, py312, py313

[testenv]
passenv = FAKE_API_ENDPOINT
Expand All @@ -10,7 +10,6 @@ commands =

[gh-actions]
python =
3.8: py38
3.9: py39
3.10: py310
3.11: py311
Expand Down

0 comments on commit e74e319

Please sign in to comment.