Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Go 1.23 #532

Merged
merged 1 commit into from
Sep 12, 2024
Merged

feat: add support for Go 1.23 #532

merged 1 commit into from
Sep 12, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Sep 9, 2024

This PR updates our Go tooling version to 1.23 while keeping the minimum required Go version for dependencies at Go 1.21.

@phm07 phm07 added the dependencies Pull requests that update a dependency file label Sep 9, 2024
@phm07 phm07 self-assigned this Sep 9, 2024
@phm07 phm07 requested a review from a team as a code owner September 9, 2024 11:39
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.46%. Comparing base (a90d4c2) to head (36a1c48).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #532   +/-   ##
=======================================
  Coverage   71.46%   71.46%           
=======================================
  Files          46       46           
  Lines        3935     3935           
=======================================
  Hits         2812     2812           
  Misses        710      710           
  Partials      413      413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola
Copy link
Member

jooola commented Sep 10, 2024

Please update the scope in the title to make the change appear in the changelog, e.g. feat: add support for go 1.23

@phm07 phm07 changed the title deps: update Go toolchain to 1.23 feat: add support for Go 1.23 Sep 12, 2024
@phm07 phm07 merged commit 838f878 into main Sep 12, 2024
5 checks passed
@phm07 phm07 deleted the go-1.23 branch September 12, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants