fix: invalid_input API errors may not return details
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The create uploaded certificate endpoint may return the following error:
{
"error": {
"code": "invalid_input",
"message": "certificate must use larger key size"
}
}
This change ensure that we do not get a json unmarshal error (unexpected end of json) while trying to parse a non existing data.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 71.46% 71.46%
=======================================
Files 46 46
Lines 3935 3935
=======================================
Hits 2812 2812
Misses 710 710
Partials 413 413 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Aug 9, 2024
apricote
added
backport release-1.x
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
The create uploaded certificate endpoint may return the following error:
```
{
"error": {
"code": "invalid_input",
"message": "certificate must use larger key size"
}
}
```
This change ensure that we do not get a json unmarshal error (unexpected
end of json) while trying to parse a non-existing details data.
(cherry picked from commit ca78af2)
This was referenced Aug 9, 2024
jooola
added a commit
that referenced
this pull request
Aug 9, 2024
…ase-1.x] (#508) The create uploaded certificate endpoint may return the following error: ``` { "error": { "code": "invalid_input", "message": "certificate must use larger key size" } } ``` This change ensure that we do not get a json unmarshal error (unexpected end of json) while trying to parse a non-existing details data. --- Backport ca78af2 from #507. BEGIN_COMMIT_OVERRIDE fix: `invalid_input` API errors may not return details END_COMMIT_OVERRIDE Co-authored-by: Jonas L. <[email protected]>
jooola
pushed a commit
that referenced
this pull request
Aug 9, 2024
🤖 I have created a release *beep* *boop* --- ## [2.13.1](v2.13.0...v2.13.1) (2024-08-09) ### Bug Fixes * `invalid_input` API errors may not return details ([#507](#507)) ([ca78af2](ca78af2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
apricote
pushed a commit
to hetznercloud/fleeting-plugin-hetzner
that referenced
this pull request
Sep 12, 2024
…3.1 (hetznercloud/fleeting-plugin-hetzner!104) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | patch | `v2.13.0` -> `v2.13.1` | --- ### Release Notes <details> <summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary> ### [`v2.13.1`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.13.1) [Compare Source](hetznercloud/hcloud-go@v2.13.0...v2.13.1) ##### Bug Fixes - `invalid_input` API errors may not return details ([#​507](hetznercloud/hcloud-go#507)) ([ca78af2](hetznercloud/hcloud-go@ca78af2)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMy4yIiwidXBkYXRlZEluVmVyIjoiMzguMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The create uploaded certificate endpoint may return the following error:
This change ensure that we do not get a json unmarshal error (unexpected end of json) while trying to parse a non-existing details data.