feat: add new WithPollOpts client option
#493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
==========================================
- Coverage 71.53% 71.47% -0.06%
==========================================
Files 46 46
Lines 3910 3916 +6
==========================================
+ Hits 2797 2799 +2
- Misses 699 704 +5
+ Partials 414 413 -1 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Jul 24, 2024
apricote
added a commit
that referenced
this pull request
Jul 25, 2024
🤖 I have created a release *beep* *boop* --- ## [2.12.0](v2.11.0...v2.12.0) (2024-07-25) ### Features * add jitter in the client default retry exponential backoff ([#492](#492)) ([6205076](6205076)) * add new `WithPollOpts` client option ([#493](#493)) ([2c1a2d6](2c1a2d6)) * allow checking multiple errors codes in `IsError` ([#491](#491)) ([af59ab8](af59ab8)) * **load-balancer-type:** new traffic price fields ([94e0f44](94e0f44)) * **pricing:** mark traffic field as deprecated ([94e0f44](94e0f44)) * **server-type:** mark included traffic field as deprecated ([94e0f44](94e0f44)) * **server-type:** new traffic price fields ([94e0f44](94e0f44)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julian Tölle <[email protected]>
apricote
pushed a commit
to hetznercloud/fleeting-plugin-hetzner
that referenced
this pull request
Sep 12, 2024
…2.0 (hetznercloud/fleeting-plugin-hetzner!101) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.11.0` -> `v2.12.0` | --- ### Release Notes <details> <summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary> ### [`v2.12.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.12.0) [Compare Source](hetznercloud/hcloud-go@v2.11.0...v2.12.0) ##### API Changes for Traffic Prices and Server Type Included Traffic There will be a breaking change in the API regarding Traffic Prices and Server Type Included Traffic on 2024-08-05. This release marks the affected fields as `Deprecated`. Please check if this affects any of your code and switch to the replacement fields where necessary. You can learn more about this change in [our changelog](https://docs.hetzner.cloud/changelog#2024-07-25-cloud-api-returns-traffic-information-in-different-format). ##### Upgrading ##### Server Type Included Traffic If you were using the field `hcloud.ServerType.IncludedTraffic`, you can now get the information through `hcloud.ServerType.Pricings`: ```go func main() { // previous includedTraffic := serverType.IncludedTraffic // now locationOfInterest := "fsn1" var includedTraffic uint64 for _, price := range serverType.Pricings { if price.Location.Name == locationOfInterest { includedTraffic = price.IncludedTraffic break } } } ``` ##### Traffic Prices If you were using the field `hcloud.Pricing.Traffic`, you can now get the information through `hcloud.Pricing.ServerTypes` or `hcloud.Pricing.LoadBalancerTypes`: ```go func main() { // previous trafficPrice := pricing.Traffic // now serverTypeOfInterest := "cx22" locationOfInterest := "fsn1" var trafficPrice hcloud.Price for _, serverTypePricings := range pricing.ServerTypes { if serverTypePricings.ServerType.Name == serverTypeOfInterest { for _, price := range serverTypePricings { if price.Location.Name == locationOfInterest { trafficPrice = price.PerTBTraffic break } } } } } ``` ##### Features - add jitter in the client default retry exponential backoff ([#​492](hetznercloud/hcloud-go#492)) ([6205076](hetznercloud/hcloud-go@6205076)) - add new `WithPollOpts` client option ([#​493](hetznercloud/hcloud-go#493)) ([2c1a2d6](hetznercloud/hcloud-go@2c1a2d6)) - allow checking multiple errors codes in `IsError` ([#​491](hetznercloud/hcloud-go#491)) ([af59ab8](hetznercloud/hcloud-go@af59ab8)) - **load-balancer-type:** new traffic price fields ([94e0f44](hetznercloud/hcloud-go@94e0f44)) - **pricing:** mark traffic field as deprecated ([94e0f44](hetznercloud/hcloud-go@94e0f44)) - **server-type:** mark included traffic field as deprecated ([94e0f44](hetznercloud/hcloud-go@94e0f44)) - **server-type:** new traffic price fields ([94e0f44](hetznercloud/hcloud-go@94e0f44)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WithRetryOpts,PollOptsstruct, which is more future-proof than function arguments (properties can be added without breaking),WithPollOptsinstead of the deprecated alternative.Since we already changed the way to configure the retry options, I think it is a good time to also change the pattern for the poll opts, even if this does not really bring a new feature.