Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow checking multiple errors codes in IsError #491

Merged
merged 2 commits into from
Jul 24, 2024
Merged

feat: allow checking multiple errors codes in IsError #491

merged 2 commits into from
Jul 24, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Jul 23, 2024 •
edited
Loading

Useful when one need to check multiple error codes at once, without having to cast every time.

-hcloud.IsError(err, hcloud.ErrorCodeConflict) || hcloud.IsError(err, hcloud.ErrorCodeLocked)
+hcloud.IsError(err, hcloud.ErrorCodeConflict, hcloud.ErrorCodeLocked)

@jooola jooola requested a review from a team as a code owner July 23, 2024 08:23
@jooola jooola requested a review from apricote July 23, 2024 08:24
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.53%. Comparing base (cf9fdaf) to head (418e4cf).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #491   +/-   ##
=======================================
  Coverage   71.53%   71.53%           
=======================================
  Files          46       46           
  Lines        3910     3910           
=======================================
  Hits         2797     2797           
  Misses        699      699           
  Partials      414      414

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

apricote
apricote reviewed Jul 23, 2024
View reviewed changes
hcloud/error.go Outdated Show resolved Hide resolved
jooola
jooola commented Jul 23, 2024
View reviewed changes
hcloud/error.go Outdated Show resolved Hide resolved
@jooola jooola merged commit af59ab8 into main Jul 24, 2024
4 checks passed
@jooola jooola deleted the check-many-api-error branch July 24, 2024 11:59
@github-actions github-actions bot mentioned this pull request Jul 24, 2024
Merged
apricote added a commit that referenced this pull request Jul 25, 2024
@github-actions @apricote
chore(main): release 2.12.0 (#494)
482aee2 
🤖 I have created a release *beep* *boop*
---


##
[2.12.0](v2.11.0...v2.12.0)
(2024-07-25)


### Features

* add jitter in the client default retry exponential backoff
([#492](#492))
([6205076](6205076))
* add new `WithPollOpts` client option
([#493](#493))
([2c1a2d6](2c1a2d6))
* allow checking multiple errors codes in `IsError`
([#491](#491))
([af59ab8](af59ab8))
* **load-balancer-type:** new traffic price fields
([94e0f44](94e0f44))
* **pricing:** mark traffic field as deprecated
([94e0f44](94e0f44))
* **server-type:** mark included traffic field as deprecated
([94e0f44](94e0f44))
* **server-type:** new traffic price fields
([94e0f44](94e0f44))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julian Tölle <[email protected]>
apricote pushed a commit to hetznercloud/fleeting-plugin-hetzner that referenced this pull request Sep 12, 2024
@jooola
fix(deps): update module github.com/hetznercloud/hcloud-go/v2 to v2.1…
c8b9275 
…2.0 (hetznercloud/fleeting-plugin-hetzner!101)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.11.0` -> `v2.12.0` |

---

### Release Notes

<details>
<summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary>

### [`v2.12.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.12.0)

[Compare Source](hetznercloud/hcloud-go@v2.11.0...v2.12.0)

##### API Changes for Traffic Prices and Server Type Included Traffic

There will be a breaking change in the API regarding Traffic Prices and Server Type Included Traffic on 2024-08-05. This release marks the affected fields as `Deprecated`. Please check if this affects any of your code and switch to the replacement fields where necessary.

You can learn more about this change in [our changelog](https://docs.hetzner.cloud/changelog#2024-07-25-cloud-api-returns-traffic-information-in-different-format).

##### Upgrading

##### Server Type Included Traffic

If you were using the field `hcloud.ServerType.IncludedTraffic`, you can now get the information through `hcloud.ServerType.Pricings`:

```go
func main() {
// previous
includedTraffic := serverType.IncludedTraffic

    // now
    locationOfInterest := "fsn1"
    var includedTraffic uint64
    for _, price := range serverType.Pricings {
        if price.Location.Name == locationOfInterest {
            includedTraffic = price.IncludedTraffic
            break
        }
    }
}
```

##### Traffic Prices

If you were using the field `hcloud.Pricing.Traffic`, you can now get the information through `hcloud.Pricing.ServerTypes` or `hcloud.Pricing.LoadBalancerTypes`:

```go
func main() {
// previous
trafficPrice := pricing.Traffic

    // now
    serverTypeOfInterest := "cx22"
    locationOfInterest := "fsn1"

    var trafficPrice hcloud.Price
    for _, serverTypePricings := range pricing.ServerTypes {
        if serverTypePricings.ServerType.Name == serverTypeOfInterest {
            for _, price := range serverTypePricings {
               if price.Location.Name == locationOfInterest {
                   trafficPrice = price.PerTBTraffic
                   break
               }
            }
        }
    }
}
```

##### Features

-   add jitter in the client default retry exponential backoff ([#&#8203;492](hetznercloud/hcloud-go#492)) ([6205076](hetznercloud/hcloud-go@6205076))
-   add new `WithPollOpts` client option ([#&#8203;493](hetznercloud/hcloud-go#493)) ([2c1a2d6](hetznercloud/hcloud-go@2c1a2d6))
-   allow checking multiple errors codes in `IsError` ([#&#8203;491](hetznercloud/hcloud-go#491)) ([af59ab8](hetznercloud/hcloud-go@af59ab8))
-   **load-balancer-type:** new traffic price fields ([94e0f44](hetznercloud/hcloud-go@94e0f44))
-   **pricing:** mark traffic field as deprecated ([94e0f44](hetznercloud/hcloud-go@94e0f44))
-   **server-type:** mark included traffic field as deprecated ([94e0f44](hetznercloud/hcloud-go@94e0f44))
-   **server-type:** new traffic price fields ([94e0f44](hetznercloud/hcloud-go@94e0f44))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apricote apricote apricote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jooola @apricote