-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exp): add hcloud client mock package #442
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 70.91% 70.54% -0.38%
==========================================
Files 35 36 +1
Lines 3772 3792 +20
==========================================
Hits 2675 2675
- Misses 688 708 +20
Partials 409 409 ☔ View full report in Codecov by Sentry. |
I started implementing the new mocks in the CLI: hetznercloud/cli@4329583 |
I am not sure to fully understand your suggestions, could you elaborate please? |
Implementing a mock for the client will be on hold until we can implement an interface first client. The current struct based client does not allow us to swap the client implementation (real and mock) easily. |
This adds a generated mock for the
hcloudmock.Client
that will be usable for external library for testing.