Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(error): include http response in api errors #320

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Conversation

apricote
Copy link
Member

This allows us to show more useful information in debug logs in downstream projects.

@apricote apricote self-assigned this Sep 19, 2023
@apricote apricote requested a review from a team as a code owner September 19, 2023 13:12
hcloud/client.go Outdated Show resolved Hide resolved
@apricote apricote changed the title feat(error): include http status code in api errors feat(error): include http response in api errors Oct 20, 2023
@apricote apricote requested a review from jooola October 20, 2023 09:11
@apricote apricote merged commit 9558239 into main Oct 20, 2023
4 checks passed
@apricote apricote deleted the error-status-code branch October 20, 2023 09:14
@apricote apricote added the backport release-1.x Open PR against release-1.x with these changes after the PR is merged. label Oct 20, 2023
github-actions bot pushed a commit that referenced this pull request Oct 20, 2023
This allows us to show more useful information in debug logs in
downstream projects.

---------

Co-authored-by: Jonas Lammler <[email protected]>
(cherry picked from commit 9558239)
apricote added a commit that referenced this pull request Oct 20, 2023
phm07 pushed a commit that referenced this pull request Dec 12, 2023
🤖 I have created a release *beep* *boop*
---


##
[2.5.0](v2.4.0...v2.5.0)
(2023-12-12)


### Features

* add conversion methods from schema to hcloud objects
([#343](#343))
([6feda4d](6feda4d))
* add interfaces for client structs
([#342](#342))
([4f9390f](4f9390f))
* add missing properties
([#349](#349))
([c8a28d0](c8a28d0))
* **error:** include http response in api errors
([#320](#320))
([9558239](9558239))


### Bug Fixes

* make schemas consistent with API
([#348](#348))
([b0d7055](b0d7055))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.x Open PR against release-1.x with these changes after the PR is merged. Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants