-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(error): include http response in api errors #320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
force-pushed
the
error-status-code
branch
from
September 19, 2023 13:28
2674463
to
8de4cfa
Compare
jooola
reviewed
Oct 13, 2023
jooola
force-pushed
the
error-status-code
branch
from
October 19, 2023 16:03
05c3234
to
5eae70c
Compare
apricote
changed the title
feat(error): include http status code in api errors
feat(error): include http response in api errors
Oct 20, 2023
jooola
approved these changes
Oct 20, 2023
apricote
added
the
backport release-1.x
Open PR against release-1.x with these changes after the PR is merged.
label
Oct 20, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
This allows us to show more useful information in debug logs in downstream projects. --------- Co-authored-by: Jonas Lammler <[email protected]> (cherry picked from commit 9558239)
This was referenced Oct 20, 2023
apricote
added a commit
that referenced
this pull request
Oct 20, 2023
Backport 9558239 from #320. Co-authored-by: Julian Tölle <[email protected]>
phm07
pushed a commit
that referenced
this pull request
Dec 12, 2023
🤖 I have created a release *beep* *boop* --- ## [2.5.0](v2.4.0...v2.5.0) (2023-12-12) ### Features * add conversion methods from schema to hcloud objects ([#343](#343)) ([6feda4d](6feda4d)) * add interfaces for client structs ([#342](#342)) ([4f9390f](4f9390f)) * add missing properties ([#349](#349)) ([c8a28d0](c8a28d0)) * **error:** include http response in api errors ([#320](#320)) ([9558239](9558239)) ### Bug Fixes * make schemas consistent with API ([#348](#348)) ([b0d7055](b0d7055)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to show more useful information in debug logs in downstream projects.