Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-1.x] fix(action): unexpected behaviour when watching non-existing Actions #300

Merged
merged 1 commit into from
Aug 8, 2023
Merged

[Backport release-1.x] fix(action): unexpected behaviour when watching non-existing Actions #300

merged 1 commit into from
Aug 8, 2023

Commits on Aug 8, 2023

  1. fix(action): unexpected behaviour when watching non-existing Actions (#… 

    …298)

When passed an action with an unknown ID, the
`ActionClient.WatchProgress()` and `ActionClient.WatchOverallProgress()`
methods experience unexpected behaviour:

- `WatchProgress()` would panic with a nil pointer dereference when
  accessing `a.Status`
- `WatchOverallProgress()` would go into an infinite loop, never
  finishing or closing the channels.

(cherry picked from commit 0727d42)
    @apricote @github-actions
    apricote authored and github-actions[bot] committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    a44e7d3 View commit details
    Browse the repository at this point in the history