Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Return consistent empty slice from .All() methods #297

Merged
merged 1 commit into from
Aug 8, 2023
Merged

refactor: Return consistent empty slice from .All() methods #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hcloud/action.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func (c *ActionClient) All(ctx context.Context) ([]*Action, error) {

// AllWithOpts returns all actions for the given options.
func (c *ActionClient) AllWithOpts(ctx context.Context, opts ActionListOpts) ([]*Action, error) {
var allActions []*Action
allActions := []*Action{}

err := c.client.all(func(page int) (*Response, error) {
opts.Page = page
Expand Down
2 changes: 1 addition & 1 deletion hcloud/certificate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ func (c *CertificateClient) All(ctx context.Context) ([]*Certificate, error) {

// AllWithOpts returns all Certificates for the given options.
func (c *CertificateClient) AllWithOpts(ctx context.Context, opts CertificateListOpts) ([]*Certificate, error) {
var allCertificates []*Certificate
allCertificates := []*Certificate{}

err := c.client.all(func(page int) (*Response, error) {
opts.Page = page
Expand Down
2 changes: 1 addition & 1 deletion hcloud/datacenter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func (c *DatacenterClient) All(ctx context.Context) ([]*Datacenter, error) {

// AllWithOpts returns all datacenters for the given options.
func (c *DatacenterClient) AllWithOpts(ctx context.Context, opts DatacenterListOpts) ([]*Datacenter, error) {
var allDatacenters []*Datacenter
allDatacenters := []*Datacenter{}

err := c.client.all(func(page int) (*Response, error) {
opts.Page = page
Expand Down
2 changes: 1 addition & 1 deletion hcloud/firewall.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ func (c *FirewallClient) All(ctx context.Context) ([]*Firewall, error) {

// AllWithOpts returns all Firewalls for the given options.
func (c *FirewallClient) AllWithOpts(ctx context.Context, opts FirewallListOpts) ([]*Firewall, error) {
var allFirewalls []*Firewall
allFirewalls := []*Firewall{}

err := c.client.all(func(page int) (*Response, error) {
opts.Page = page
Expand Down
2 changes: 1 addition & 1 deletion hcloud/floating_ip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ func (c *FloatingIPClient) All(ctx context.Context) ([]*FloatingIP, error) {

// AllWithOpts returns all Floating IPs for the given options.
func (c *FloatingIPClient) AllWithOpts(ctx context.Context, opts FloatingIPListOpts) ([]*FloatingIP, error) {
var allFloatingIPs []*FloatingIP
allFloatingIPs := []*FloatingIP{}

err := c.client.all(func(page int) (*Response, error) {
opts.Page = page
Expand Down
2 changes: 1 addition & 1 deletion hcloud/iso.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ func (c *ISOClient) All(ctx context.Context) ([]*ISO, error) {

// AllWithOpts returns all ISOs for the given options.
func (c *ISOClient) AllWithOpts(ctx context.Context, opts ISOListOpts) ([]*ISO, error) {
allISOs := make([]*ISO, 0)
allISOs := []*ISO{}

err := c.client.all(func(page int) (*Response, error) {
opts.Page = page
Expand Down
2 changes: 1 addition & 1 deletion hcloud/load_balancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ func (c *LoadBalancerClient) All(ctx context.Context) ([]*LoadBalancer, error) {

// AllWithOpts returns all Load Balancers for the given options.
func (c *LoadBalancerClient) AllWithOpts(ctx context.Context, opts LoadBalancerListOpts) ([]*LoadBalancer, error) {
var allLoadBalancers []*LoadBalancer
allLoadBalancers := []*LoadBalancer{}

err := c.client.all(func(page int) (*Response, error) {
opts.Page = page
Expand Down
2 changes: 1 addition & 1 deletion hcloud/load_balancer_type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ func (c *LoadBalancerTypeClient) All(ctx context.Context) ([]*LoadBalancerType,

// AllWithOpts returns all Load Balancer types for the given options.
func (c *LoadBalancerTypeClient) AllWithOpts(ctx context.Context, opts LoadBalancerTypeListOpts) ([]*LoadBalancerType, error) {
var allLoadBalancerTypes []*LoadBalancerType
allLoadBalancerTypes := []*LoadBalancerType{}

err := c.client.all(func(page int) (*Response, error) {
opts.Page = page
Expand Down
2 changes: 1 addition & 1 deletion hcloud/location.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ func (c *LocationClient) All(ctx context.Context) ([]*Location, error) {

// AllWithOpts returns all locations for the given options.
func (c *LocationClient) AllWithOpts(ctx context.Context, opts LocationListOpts) ([]*Location, error) {
var allLocations []*Location
allLocations := []*Location{}

err := c.client.all(func(page int) (*Response, error) {
opts.Page = page
Expand Down
2 changes: 1 addition & 1 deletion hcloud/network.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ func (c *NetworkClient) All(ctx context.Context) ([]*Network, error) {

// AllWithOpts returns all networks for the given options.
func (c *NetworkClient) AllWithOpts(ctx context.Context, opts NetworkListOpts) ([]*Network, error) {
var allNetworks []*Network
allNetworks := []*Network{}

err := c.client.all(func(page int) (*Response, error) {
opts.Page = page
Expand Down
2 changes: 1 addition & 1 deletion hcloud/placement_group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func (c *PlacementGroupClient) All(ctx context.Context) ([]*PlacementGroup, erro

// AllWithOpts returns all PlacementGroups for the given options.
func (c *PlacementGroupClient) AllWithOpts(ctx context.Context, opts PlacementGroupListOpts) ([]*PlacementGroup, error) {
var allPlacementGroups []*PlacementGroup
allPlacementGroups := []*PlacementGroup{}

err := c.client.all(func(page int) (*Response, error) {
opts.Page = page
Expand Down
2 changes: 1 addition & 1 deletion hcloud/primary_ip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ func (c *PrimaryIPClient) All(ctx context.Context) ([]*PrimaryIP, error) {

// AllWithOpts returns all Primary IPs for the given options.
func (c *PrimaryIPClient) AllWithOpts(ctx context.Context, opts PrimaryIPListOpts) ([]*PrimaryIP, error) {
var allPrimaryIPs []*PrimaryIP
allPrimaryIPs := []*PrimaryIP{}

err := c.client.all(func(page int) (*Response, error) {
opts.Page = page
Expand Down
2 changes: 1 addition & 1 deletion hcloud/server_type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func (c *ServerTypeClient) All(ctx context.Context) ([]*ServerType, error) {

// AllWithOpts returns all server types for the given options.
func (c *ServerTypeClient) AllWithOpts(ctx context.Context, opts ServerTypeListOpts) ([]*ServerType, error) {
var allServerTypes []*ServerType
allServerTypes := []*ServerType{}

err := c.client.all(func(page int) (*Response, error) {
opts.Page = page
Expand Down
Loading