Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation): multiple instrumented clients cause panic #289

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

apricote
Copy link
Member

Fixes #288

@apricote apricote added the Bug label Jul 14, 2023
@apricote apricote self-assigned this Jul 14, 2023
@apricote apricote force-pushed the fix-instrumentation-multiple-clients branch from b55246e to d3e8743 Compare July 14, 2023 13:26
@apricote apricote marked this pull request as ready for review July 14, 2023 13:26
@apricote apricote requested a review from a team as a code owner July 14, 2023 13:26
Copy link
Member

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@apricote apricote added the backport release-1.x Open PR against release-1.x with these changes after the PR is merged. label Jul 14, 2023
@apricote apricote merged commit c0ef9b6 into main Jul 14, 2023
4 checks passed
@apricote apricote deleted the fix-instrumentation-multiple-clients branch July 14, 2023 13:31
github-actions bot pushed a commit that referenced this pull request Jul 14, 2023
apricote added a commit that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.x Open PR against release-1.x with these changes after the PR is merged. Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: panic when multiple hcloud-go Client with Instrumentation are registered
2 participants