refactor: move regexp compilation outside function (#485)

This improves the performances a bit.
hetznercloud · Jul 16, 2024 · f7ac563 · f7ac563
1 parent 756f605
commit f7ac563
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/hcloud/internal/instrumentation/metrics.go b/hcloud/internal/instrumentation/metrics.go
@@ -102,12 +102,13 @@ func registerOrReuse[C prometheus.Collector](registry prometheus.Registerer, col
 	return collector
 }
 
+var pathLabelRegexp = regexp.MustCompile("[^a-z/_]+")
+
 func preparePathForLabel(path string) string {
 	path = strings.ToLower(path)
 
 	// replace all numbers and chars that are not a-z, / or _
-	reg := regexp.MustCompile("[^a-z/_]+")
-	path = reg.ReplaceAllString(path, "")
+	path = pathLabelRegexp.ReplaceAllString(path, "")
 
 	// replace all artifacts of number replacement (//)
 	path = strings.ReplaceAll(path, "//", "/")