fix(deployment): revert #560: remove dns-policy #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2c83786. The commit caused a regression where clusters not using the host network were unable to bootstrap successfully: - CoreDNS did not start because the Node was still tainted as uninitalized - HCCM could not initialize the Node because it failed to resolve the DNS entry for "api.hetzner.cloud".
|
I am going to remove the changelog entries for both PRs, to reduce noise in the changelog. |
jooola
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2c83786 / #560.
The commit caused a regression where clusters not using the host network were unable to bootstrap successfully:
BEGIN_COMMIT_OVERRIDE
chore: revert #560
END_COMMIT_OVERRIDE