Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable IPv6 for load balancers #194

Merged
merged 1 commit into from
May 6, 2021

Conversation

fhofherr
Copy link
Contributor

@fhofherr fhofherr commented May 5, 2021

Enabling IPv6 by default in #137 broke clusters using external-dns. This
commit adds an option to disable IPv6 by setting the

load-balancer.hetzner.cloud/ipv6-disabled

annotation to true.

Closes #191

@fhofherr fhofherr requested a review from LKaemmerling May 5, 2021 13:08
@fhofherr fhofherr marked this pull request as draft May 5, 2021 14:22
@LKaemmerling
Copy link
Member

I would invert the annotation name, because otherwise you have Double „no“. (EnableIPv6 that defaults to true is better than having DisableIPv6 that defaults to false and when it is false it disables IPv6)

Enabling IPv6 by default in #137 broke clusters using external-dns. This
commit adds an option to disable IPv6 by setting the

    load-balancer.hetzner.cloud/ipv6-disabled

annotation to true.

Closes #191
@fhofherr fhofherr force-pushed the 191-load-balancer-ipv6-enable-disable branch from 00affbf to fcdc129 Compare May 6, 2021 08:34
@fhofherr
Copy link
Contributor Author

fhofherr commented May 6, 2021

I would invert the annotation name, because otherwise you have Double „no“. (EnableIPv6 that defaults to true is better than having DisableIPv6 that defaults to false and when it is false it disables IPv6)

Only the commit message was wrong. The annotation has to be set to true of course to disable ipv6.

@fhofherr fhofherr marked this pull request as ready for review May 6, 2021 08:55
@fhofherr fhofherr merged commit b54847b into master May 6, 2021
@fhofherr fhofherr deleted the 191-load-balancer-ipv6-enable-disable branch May 6, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling IPv6 for loadbalancers
2 participants