Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm-chart): add extraParam for StorageClass #865

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

binlan
Copy link
Contributor

@binlan binlan commented Jan 27, 2025

add the ability to set custom parameters for storageclass to enable e.g. luks disk encryption or set fstype

@binlan binlan requested a review from a team as a code owner January 27, 2025 14:51
Copy link
Contributor

@lukasmetzner lukasmetzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

thank you for your contribution ^^ I only have some requests with respect to formatting and naming.

chart/values.yaml Outdated Show resolved Hide resolved
chart/templates/core/storageclass.yaml Outdated Show resolved Hide resolved
@lukasmetzner lukasmetzner changed the title FEAT: (helm-chart) add extraParam for StorageClass feat(helm-chart): add extraParam for StorageClass Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.35%. Comparing base (c83112f) to head (d61319e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #865   +/-   ##
=======================================
  Coverage   32.35%   32.35%           
=======================================
  Files          21       21           
  Lines        2077     2077           
=======================================
  Hits          672      672           
  Misses       1371     1371           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

binlan and others added 2 commits January 30, 2025 09:59
@lukasmetzner lukasmetzner merged commit 111a377 into hetznercloud:main Feb 3, 2025
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants