Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure builds for arm64 #471

Merged
merged 3 commits into from
Aug 21, 2023
Merged

configure builds for arm64 #471

merged 3 commits into from
Aug 21, 2023

Conversation

s4ke
Copy link
Contributor

@s4ke s4ke commented Aug 1, 2023 •
edited
Loading

(hopefully) fixes #428

What I did do:

  • adapted the Makefile
  • Checked if everything compiled properly
  • adapted the GitHub Actions

What I did not do:

  • Manually test on a Cloud Server for AMD64
  • Manually test on a Cloud Server for ARM64

@s4ke s4ke requested a review from a team as a code owner August 1, 2023 19:14
apricote
apricote reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @s4ke!

deploy/docker-swarm/pkg/Dockerfile Outdated Show resolved Hide resolved
@s4ke
Copy link
Contributor Author

s4ke commented Aug 4, 2023

@apricote should be fine now, right?

@s4ke s4ke requested a review from apricote August 20, 2023 16:19
@apricote
Copy link
Member

Lets merge and see if the publishing works through GH Actions :)

@apricote apricote merged commit 2b9c067 into hetznercloud:main Aug 21, 2023
1 of 5 checks passed
@hcloud-bot hcloud-bot mentioned this pull request Aug 25, 2023
Merged
lukasmetzner pushed a commit that referenced this pull request Oct 10, 2024
@s4ke
feat(docker-swarm): configure builds for arm64 (#471)
246d1e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apricote apricote apricote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing support for arm64/aarch64 cloud servers on Docker Swarm
2 participants
@s4ke @apricote