refactor: prepare for e2e tests #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
==========================================
+ Coverage 61.46% 66.95% +5.49%
==========================================
Files 238 240 +2
Lines 8548 8656 +108
==========================================
+ Hits 5254 5796 +542
+ Misses 2582 2147 -435
- Partials 712 713 +1 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Sep 16, 2024
Comment on lines
+16
to
+18
| // Make sure we don't have any environment variables set that could interfere with the test | ||
| t.Setenv("HCLOUD_TOKEN", "") | ||
| t.Setenv("HCLOUD_CONTEXT", "") |
There was a problem hiding this comment.
To be on the safe side we could get the env for all variables with prefix HCLOUD_ and unset them.
Unfortunately Go has no os.GetEnvMap(), and os.Environ() returns []string with KEY=VALUE pairs, so lots of additional effort to parse it and I am not sure its worth it.
There was a problem hiding this comment.
Ideally you would want a "fresh" env anyway but I don't think there is a way to do that in Go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds refactors that are necessary for the e2e tests.
Changes:
internal/cli/root.gooutput.Tables now accept writers as output. This is needed to catch command output. If we only catch stdout we can only run one command at once or there will be interference.