test: use client interfaces provided by hcloud-go for mocking #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
reviewed
Nov 16, 2023
phm07
force-pushed
the
use-hcloud-client-interfaces
branch
from
764747a
to
9a5c5a9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 31.61% 31.61%
=======================================
Files 171 171
Lines 7885 7885
=======================================
Hits 2493 2493
Misses 5108 5108
Partials 284 284 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once hetznercloud/hcloud-go#342 is merged,
hcloud-goprovides its own interfaces for clients. We can thus remove the ones we generated ourselves and use the provided ones instead. Also, theinterfacertool can be removed.