Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying initial attachment name when creating addon. #231

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidji99
Copy link
Collaborator

Resolves #227

@davidji99 davidji99 self-assigned this Aug 6, 2019
@davidji99
Copy link
Collaborator Author

davidji99 commented Aug 6, 2019

From what I experienced initially, the Heroku Platform API does two things:

  • Does not return attachment.name in the either the POST or GET call to /apps/{app_id_or_name}/addons. It does show up in the UI:

Screen Shot 2019-08-06 at 3 22 24 PM

So I am wondering if the provider needs to somehow use another endpoint to lookup if the attachment_name is set properly.

  • Does not allow you to update the attachment name as the following error is returned when attempting to do so:
{
    "id": "invalid_params",
    "message": "Unknown params: attachment:name."
}

Therefore, the new heroku_addon.attachment_name attribute will be set to ForceNew as it cannot be updated, only set on initial creation.


Questions to answer:

  • What happens when someone has a heroku_addon_attachment resource that specifies a different name? Could this cause an infinite dirty plan?
  • Should we rename heroku_addon.name and heroku_addon.attachment_name? At first look, the naming sounds reasonable since it's verbatim from the Platform API documentation.
  • Any issues when running a new provider version on an existing tf configuration code base?

@ghost ghost added size/S and removed size/XS labels Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying initial attachment name when creating addon.
1 participant