Pre-heroku-24 cleanup #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is typically set in the outside environment e.g. on dynos, but when testing this locally, being in the wrong working dir (without a composer.json) would cause Composer to prompt for a path, and then the boot hangs forever.
Ubuntu 24 only has that binary now. For boot, this is really for weird cases only where there is no 'realpath' (used to be the case on macOS years ago).
It uses heroku/php once and then the 'current' buildpack, instead of the 'current' buildpack twice. That won't work if there are changes such as... a new stack :)
edmorley
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just three little fixes:
COMPOSER_NO_INTERACTION=1inside boot scripts (this is only relevant when testing them locally, as the buildpack sets this during builds and runtime)python3throughout for invocation of Python, since that's what most environments now haveheroku/phponce, which might not succeed a build on e.g. a new stack