Skip to content

Commit

Permalink
Split ci_frameworks_spec into two
Browse files Browse the repository at this point in the history
Those are the slowest tests, so it helps a lot with overall time and with parallelization
  • Loading branch information
dzuelke committed Mar 6, 2024
1 parent 6e8574c commit 2301601
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 6 deletions.
20 changes: 20 additions & 0 deletions test/spec/ci_frameworks-a_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
require_relative "spec_helper"

describe "A PHP application on Heroku CI" do
{
"atoum": "atoum",
"Behat": "behat",
"Codeception": "codecept run",
}.each do |name, command|
context "using the #{name} CI framework" do
let(:app) {
new_app_with_stack_and_platrepo("test/fixtures/ci/#{name.downcase}")
}
it "automatically executes '#{command}'" do
app.run_ci do |test_run|
expect(test_run.output).to match("#{name} found, executing '#{command}'...")
end
end
end
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,8 @@

describe "A PHP application on Heroku CI" do
{
"Codeception": "codecept run",
"Behat": "behat",
"PHPSpec": "phpspec run",
"atoum": "atoum",
"Kahlan": "kahlan",
"PHPSpec": "phpspec run",
"PHPUnit": "phpunit",
}.each do |name, command|
context "using the #{name} CI framework" do
Expand Down
3 changes: 2 additions & 1 deletion test/var/log/parallel_runtime_rspec.heroku-20.log
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
test/spec/blackfire-buildpackagent_spec.rb:100
test/spec/blackfire-herokuagent_spec.rb:120
test/spec/bugs_spec.rb:30
test/spec/ci_frameworks_spec.rb:190
test/spec/ci_frameworks-a_spec.rb:120
test/spec/ci_frameworks-k_spec.rb:120
test/spec/ci_spec.rb:125
test/spec/composer-1_spec.rb:50
test/spec/composer-2_spec.rb:90
Expand Down
3 changes: 2 additions & 1 deletion test/var/log/parallel_runtime_rspec.heroku-22.log
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
test/spec/blackfire-buildpackagent_spec.rb:100
test/spec/blackfire-herokuagent_spec.rb:120
test/spec/bugs_spec.rb:30
test/spec/ci_frameworks_spec.rb:190
test/spec/ci_frameworks-a_spec.rb:120
test/spec/ci_frameworks-k_spec.rb:120
test/spec/ci_spec.rb:125
test/spec/composer-2_spec.rb:90
test/spec/devcenter_spec.rb:5
Expand Down

0 comments on commit 2301601

Please sign in to comment.