Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: enable SCRAM support #193

Merged
merged 3 commits into from
May 23, 2024
Merged

maint: enable SCRAM support #193

merged 3 commits into from
May 23, 2024

Commits on May 21, 2024

  1. maint: enable SCRAM support 

    In order to support SCRAM support for the new Heroku Postgres
"Essential" plans, we need to shift from MD5 hashed passwords in
`auth_file` to plain text. This does not materially change the threat
model, as anyone with dyno access can read the passwords from the
environment just as well as the file.

See: https://www.pgbouncer.org/config.html#authentication-file-format
for more.

This commit switches the `auth_type` to `scram-sha-256` and also pushes
`server_tls_sslmode` up to `require` over `prefer`.

Why not use a method like `auth_query`? Exposing something like
`pg_authid` or `pg_shadow` in a safe way via a `SECURITY DEFINER`
function is extremely challenging in a multi-tenant environment. This
may change in the future.

Fixes #155.

Ref: https://gus.my.salesforce.com/a07EE00001rjvVBYAY
    @mble-sfdc
    mble-sfdc committed May 21, 2024
    Configuration menu
    Copy the full SHA
    17cb11a View commit details
    Browse the repository at this point in the history

  2. update tests

    @mble-sfdc
    mble-sfdc committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e7c5b91 View commit details
    Browse the repository at this point in the history

  3. add updates from feedback

    @mble-sfdc
    mble-sfdc committed May 21, 2024
    Configuration menu
    Copy the full SHA
    49fb549 View commit details
    Browse the repository at this point in the history