Migrate from bcpkix-jdk15on to bcpkix-jdk18on
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
force-pushed
the
malax/bcpkix-jdk18on
branch
from
3698b75
to
4d8925a
Compare
edmorley
approved these changes
Sep 27, 2024
Malax
force-pushed
the
malax/bcpkix-jdk18on
branch
from
4d8925a
to
70668c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from
bcpkix-jdk15ontobcpkix-jdk18on. The former was historically used to denote a Java 5+ compatible version of the dependency. The package was renamed and changed to a Java 8+ version at some point. The old dependency doesn't get any more updates and somehow Dependabot wasn't able to figure this out for us.I will investigate why this happened and how we can prevent this from happening in the future.
The upgrade to Java 8+ is not a problem since this library requires Java 8 anyways.
Reported by @khfds2024 in #90 - Thanks!