Add heroku/builder:20
#394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The builder images in this repository fall into two main groups: 1. The legacy `heroku/buildpacks:*` builder namespace that use a mixture of native CNBs and shimmed classic buildpacks. 2. The newer `heroku/builder:*` builder namespace that uses only native (non-shimmed) CNBs. Previously, if someone wanted to use the newer builder image type they had to use `heroku/builder:22` which is based on the Heroku-22 stack (Ubuntu 22.04). Now, if someone needs to use Heroku-20 (Ubuntu 20.04), they can do so via a new `heroku/builder:20` image, rather than needing to fall back to the older `heroku/buildpacks:20` image and its shimmed classic buildpacks. This will make it easier for us to deprecate `heroku/buildpacks:20` in future PRs, since there will now be an easier upgrade paths for users that need eg older language runtime versions of Python/Ruby/PHP etc. The new `heroku/builder:20` builder image variant is identical to `heroku/builder:22`, except: - it uses Heroku-20 based run/build-images - it doesn't include the java/node.js functions buildpacks (which are due to be removed from `heroku/builder:22` soon in favour of the newly added salesforce-functions image variant). For more details, see: https://salesforce.quip.com/0JtbAYiWZYk6 GUS-W-14184901.
dzuelke
approved these changes
Sep 26, 2023
edmorley
added a commit
to heroku/languages-github-actions
that referenced
this pull request
Sep 26, 2023
) Adds the two new builder image variants recently added to the `heroku/builder` repo: - heroku/cnb-builder-images#392 - heroku/cnb-builder-images#394 GUS-W-14185090.
|
Branch protection list of required CI checks updated. |
This was referenced Sep 26, 2023
edmorley
added a commit
to heroku/buildpacks-nodejs
that referenced
this pull request
Sep 26, 2023
Since the `heroku/buildpacks:20` image is about to be deprecated, and has been replaced by the newly added `heroku/builder:20` for those that need to use a Heroku-20 based builder. The build and run images used by `heroku/builder:20` are the same as those used by `heroku/buildpacks:20` - the only differences between the builders are the included buildpacks (which is somewhat irrelevant for these integration tests, since the buildpack under test will be injected instead). The smoke tests in the `heroku/builder` GitHub repo are still testing against all image variants (until such time as we make the legacy images error with an EOL message), so we still have test coverage against them. See: heroku/cnb-builder-images#394 https://salesforce.quip.com/0JtbAYiWZYk6 GUS-W-14186015.
edmorley
added a commit
to heroku/buildpacks-go
that referenced
this pull request
Sep 27, 2023
Since the `heroku/buildpacks:20` image is about to be deprecated, and has been replaced by the newly added `heroku/builder:20` for those that need to use a Heroku-20 based builder. The build and run images used by `heroku/builder:20` are the same as those used by `heroku/buildpacks:20` - the only differences between the builders are the included buildpacks (which is somewhat irrelevant for these integration tests, since the buildpack under test will be injected instead). The smoke tests in the `heroku/builder` GitHub repo are still testing against all image variants (until such time as we make the legacy images error with an EOL message), so we still have test coverage against them. See: heroku/cnb-builder-images#394 https://salesforce.quip.com/0JtbAYiWZYk6 GUS-W-14186015.
edmorley
added a commit
to heroku/buildpacks-jvm
that referenced
this pull request
Sep 27, 2023
Since the `heroku/buildpacks:20` image is about to be deprecated, and has been replaced by the newly added `heroku/builder:20` for those that need to use a Heroku-20 based builder. The build and run images used by `heroku/builder:20` are the same as those used by `heroku/buildpacks:20` - the only differences between the builders are the included buildpacks (which is somewhat irrelevant for these integration tests, since the buildpack under test will be injected instead). The smoke tests in the `heroku/builder` GitHub repo are still testing against all image variants (until such time as we make the legacy images error with an EOL message), so we still have test coverage against them. See: heroku/cnb-builder-images#394 https://salesforce.quip.com/0JtbAYiWZYk6 GUS-W-14186015.
edmorley
added a commit
to heroku/buildpacks-php
that referenced
this pull request
Sep 27, 2023
Since the `heroku/buildpacks:20` image is about to be deprecated, and has been replaced by the newly added `heroku/builder:20` for those that need to use a Heroku-20 based builder. The build and run images used by `heroku/builder:20` are the same as those used by `heroku/buildpacks:20` - the only differences between the builders are the included buildpacks (which is somewhat irrelevant for these integration tests, since the buildpack under test will be injected instead). The smoke tests in the `heroku/builder` GitHub repo are still testing against all image variants (until such time as we make the legacy images error with an EOL message), so we still have test coverage against them. See: heroku/cnb-builder-images#394 https://salesforce.quip.com/0JtbAYiWZYk6 GUS-W-14186015.
edmorley
added a commit
to heroku/buildpacks-python
that referenced
this pull request
Sep 27, 2023
Since the `heroku/buildpacks:20` image is about to be deprecated, and has been replaced by the newly added `heroku/builder:20` for those that need to use a Heroku-20 based builder. The build and run images used by `heroku/builder:20` are the same as those used by `heroku/buildpacks:20` - the only differences between the builders are the included buildpacks (which is somewhat irrelevant for these integration tests, since the buildpack under test will be injected instead). The smoke tests in the `heroku/builder` GitHub repo are still testing against all image variants (until such time as we make the legacy images error with an EOL message), so we still have test coverage against them. See: heroku/cnb-builder-images#394 https://salesforce.quip.com/0JtbAYiWZYk6 GUS-W-14186015.
edmorley
added a commit
to heroku/libcnb.rs
that referenced
this pull request
Sep 27, 2023
Since the `heroku/buildpacks:20` image is about to be deprecated, and has been replaced by the newly added `heroku/builder:20` for those that need to use a Heroku-20 based builder. The build and run images used by `heroku/builder:20` are the same as those used by `heroku/buildpacks:20` - the only differences between the builders are the included buildpacks (which is somewhat irrelevant for these integration tests, since the buildpack under test will be injected instead). See: heroku/cnb-builder-images#394 https://salesforce.quip.com/0JtbAYiWZYk6 GUS-W-14186015.
jkutner
pushed a commit
to buildpacks/pack
that referenced
this pull request
Oct 16, 2023
The `heroku/buildpacks:20` builder has been superseded by `heroku/builder:20`, and the old builder is about to be deprecated: heroku/cnb-builder-images#394 https://github.com/heroku/cnb-builder-images/blob/main/README.md As such, the suggested/trusted builders list has been updated accordingly. I've also tweaked the Heroku builder descriptions to: - mention the underlying Linux distro - fix the alphabetical ordering of supported buildpack languages Signed-off-by: Ed Morley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builder images in this repository fall into two main groups:
heroku/buildpacks:*builder namespace that use a mixture of native CNBs and shimmed classic buildpacks.heroku/builder:*builder namespace that uses only native (non-shimmed) CNBs.Previously, if someone wanted to use the newer builder image type they had to use
heroku/builder:22which is based on the Heroku-22 stack (Ubuntu 22.04).Now, if someone needs to use Heroku-20 (Ubuntu 20.04), they can do so via a new
heroku/builder:20image, rather than needing to fall back to the olderheroku/buildpacks:20image and its shimmed classic buildpacks.This will make it easier for us to deprecate
heroku/buildpacks:20in future PRs, since there will now be an easier upgrade paths for users that need eg older language runtime versions of Python/Ruby/PHP etc.The new
heroku/builder:20builder image variant is identical toheroku/builder:22, except:heroku/builder:22soon in favour of the newly added internal Salesforce Functions image variant).When this is merged, we'll also need to:
builder.tomlupdate list languages-github-actions#144)For more details, see:
https://salesforce.quip.com/0JtbAYiWZYk6
GUS-W-14184901.