Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to match Heroku Cloud Native Buildpack guidelines #176

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Update README.md to match Heroku Cloud Native Buildpack guidelines #176

merged 2 commits into from
Mar 8, 2024

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Mar 5, 2024 •
edited
Loading

This PR updates the README.md according to the guideline set forth here.

To see the new README.md without the diff: Readable

The Application Requirements and Configuration section were imported with minor changes from the https://github.com/heroku/heroku-buildpack-python README.md.

@joshwlewis joshwlewis added the skip changelog Skip the check-changelog check label Mar 5, 2024
@joshwlewis joshwlewis marked this pull request as ready for review March 5, 2024 18:43
@joshwlewis joshwlewis requested a review from a team as a code owner March 5, 2024 18:43
@edmorley
Update Python-specific app requirements and configuration sections
6bcfa18 
The buildpack doesn't support Pipenv or `setup.py`-only projects.
@edmorley edmorley added the documentation Improvements or additions to documentation label Mar 7, 2024
edmorley
edmorley approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I tweaked the Python-specific app requirements and configuration sections.

This is good to go now from my side (I won't merge myself, in case you had any other tweaks to make to the other parts).

@joshwlewis joshwlewis merged commit 94b8c4e into main Mar 8, 2024
6 checks passed
@joshwlewis joshwlewis deleted the update-readme branch March 8, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees

@edmorley edmorley

@joshwlewis joshwlewis

Labels
documentation Improvements or additions to documentation skip changelog Skip the check-changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshwlewis @edmorley