Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unified Heroku buildpack output style #745

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Use unified Heroku buildpack output style #745

wants to merge 7 commits into from

Conversation

Malax
Copy link
Member

@Malax Malax commented Nov 22, 2024

This PR introduces a new shared library for all JVM buildpacks that implements the unified Heroku buildpack output style. All buildpacks in the repository have been modified to use this new shared library over the log module from libherokubuildpack.

In some cases, the buildpacks changes their output a little bit more to output more detailed information about the process. For example, the jvm buildpack now tells the user where the OpenJDK version is defined.

Example

# Heroku OpenJDK Buildpack

- OpenJDK version resolution
  - Using version string provided in `system.properties`
  - Selected major version `11` resolves to `11.0.25`
- OpenJDK Installation
  - Downloading and unpacking OpenJDK distribution
  - Done (50.5s)
- Applying JDK overlay
  - Skipping (directory `.jdk_overlay` not present)
- Linking base image certificates as OpenJDK keystore
  - Done.

# Heroku Maven Buildpack

- Installing Maven
  - Skipping (Maven wrapper detected)
- Running Maven build
  - Running `./mvnw -DskipTests clean install`
    Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8
    [INFO] Scanning for projects...
    [INFO]
    [INFO] -------------------< com.heroku:simple-http-service >-------------------
    [INFO] Building simple-http-service 1.0-SNAPSHOT
    [INFO] --------------------------------[ jar ]---------------------------------

Closes:
W-17215812
W-17215820
W-17215822
W-17215818

@schneems
Copy link
Contributor

schneems commented Dec 3, 2024

Not a blocker, but would help for QA-ing the output as a whole to print the getting started guide in CI. https://github.com/heroku/buildpacks-ruby/blob/187770e700a433cf9e6af678cb3eb5735b89eec5/.github/workflows/ci.yml#L62-L97

shared/src/output.rs Outdated Show resolved Hide resolved
shared/src/output.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge #761, put this back in draft state and make changes until you're happy with the output (removal of newlines, using the correct style for a "value" etc.) Then we can iterate on the output style. Happy to iterate/pair too.

@Malax Malax marked this pull request as draft January 9, 2025 12:05
@Malax Malax marked this pull request as ready for review January 9, 2025 12:31
@Malax
Copy link
Member Author

Malax commented Jan 9, 2025

All (still applicable) comments have been addressed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants