-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use unified Heroku buildpack output style #745
base: main
Are you sure you want to change the base?
Conversation
fd1dfb3
to
cdddeec
Compare
Not a blocker, but would help for QA-ing the output as a whole to print the getting started guide in CI. https://github.com/heroku/buildpacks-ruby/blob/187770e700a433cf9e6af678cb3eb5735b89eec5/.github/workflows/ci.yml#L62-L97 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge #761, put this back in draft state and make changes until you're happy with the output (removal of newlines, using the correct style for a "value" etc.) Then we can iterate on the output style. Happy to iterate/pair too.
All (still applicable) comments have been addressed. :) |
This PR introduces a new shared library for all JVM buildpacks that implements the unified Heroku buildpack output style. All buildpacks in the repository have been modified to use this new shared library over the
log
module fromlibherokubuildpack
.In some cases, the buildpacks changes their output a little bit more to output more detailed information about the process. For example, the
jvm
buildpack now tells the user where the OpenJDK version is defined.Example
Closes:
W-17215812
W-17215820
W-17215822
W-17215818