-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
This looks good to me! Can you actually put the Heroku Redis section before Redis To Go? I think it makes more sense that way. |
@singingwolfboy Thanks - have swapped those sections around now. Is it ok that for someone using both Heroku Redis and Redis To Go, Redis To Go would take precedence? Not that I can think of a different way of handling someone using both add-ons at the same time :) |
Actually, because you're using |
app.config.setdefault('REDIS_HOST', url.hostname) | ||
app.config.setdefault('REDIS_PORT', url.port) | ||
app.config.setdefault('REDIS_PASSWORD', url.password) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove trailing whitespace from this line.
@singingwolfboy Thanks - whitespace removed (and I'll watch out for that in future) |
@mattstibbs You missed a line :) |
@singingwolfboy Ah damn. Think I've got it now? (thanks for being patient!) |
Add support for Heroku Redis
I apologize but I haven't had a chance to get to my PR yet. I'm still going to create a new PR - and I'll do it ASAP, as I know that the release is waiting! Thanks. |
@brainix: no worries, I know how life can get in the way. 😄 There's no hurry. If I don't get a PR from you in a few days, I'll cut a release without it, but we can always make another release after your PR gets in. |
Thanks for understanding! |
Added support for Heroku Redis which sets an environment variable of REDIS_URL.
Not sure if I've missed some implication of simply adding like this but worth a pull request!