Breaking Change: Improved VirtAddr & PhysAddr
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by x86_64: - Addition of two addresses makes no sense - Difference of two addresses should yield a u64, not an address - Opinionated: Arithmetics with usize shall not exist for addresses to avoid inconsistent behaviour on 32/64-bit systems. Be explicit when using usizes.
jounathaen
force-pushed
the
arithmetic_fix
branch
from
9fbb331 to
8bcc80f
Compare
mkroening
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
VirtAddrandPhysAddrbehave more similar tox86_64:newfn with same signatureavoid inconsistent behaviour on 32/64-bit systems. Be explicit when
using usizes