virtq: use enum_dispatch #1671
Open
virtq: use enum_dispatch #1671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
requested changes
May 7, 2025
| @@ -878,7 +879,7 @@ pub(crate) enum VirtioDriver { | |||
| ))] | |||
| Network(VirtioNetDriver), | |||
| #[cfg(feature = "vsock")] | |||
| Vsock(VirtioVsockDriver), | |||
| Vsock(Box<VirtioVsockDriver>), | |||
There was a problem hiding this comment.
Clippy was complaining about the enum variants having vastly different sizes. I'm not really sure whether we want to box here or not. It's probably very unlikely that all of them are enabled at once...
There was a problem hiding this comment.
Ah, sure. In that case, it makes sense. 👍
Closes hermit-os#989 Co-authored-by: Jens Reidel <[email protected]>
Gelbpunkt
force-pushed
the
virtq-no-dynamic-dispatch
branch
from
063ae46 to
1c0ff9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of some unneeded dynamic dispatch.
Closes #989
Supersedes #1406 (this is a rebased and slightly fixed up version of that PR)