This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
add spec derivation private bjj from ethereum account #85
Open
krlosMata
wants to merge
2
commits into
master
Choose a base branch
from
feature/add-section-derive-bjj
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffprestes
suggested changes
Aug 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the items I am asking to add it's because we had to implement this in Go and those step were not documented. These items may look silly but for whom needed to implement from scratch all those steps are not easy without a very detailed documentation and examples.
jleebee
suggested changes
Aug 27, 2021
druiz0992
previously approved these changes
Sep 17, 2021
jleebee
reviewed
Sep 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few edits : )
krlosMata
force-pushed
the
feature/add-section-derive-bjj
branch
from
September 22, 2021 13:16
f129fba
to
3eb3643
Compare
jleebee
suggested changes
Sep 24, 2021
krlosMata
force-pushed
the
feature/add-section-derive-bjj
branch
from
September 24, 2021 10:35
3eb3643
to
7c154b4
Compare
jleebee
approved these changes
Sep 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Derive private babyjubjub from ethereum account