Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

add spec derivation private bjj from ethereum account #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

krlosMata
Copy link
Contributor

This PR does the following:

  • fix index
  • add section Derive private babyjubjub from ethereum account
    • explains how Hermez derives private babyjubjub key in their SDKs from an ethereum account

Copy link

@jeffprestes jeffprestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the items I am asking to add it's because we had to implement this in Go and those step were not documented. These items may look silly but for whom needed to implement from scratch all those steps are not easy without a very detailed documentation and examples.

docs/developers/sdk.md Outdated Show resolved Hide resolved
docs/developers/sdk.md Outdated Show resolved Hide resolved
docs/developers/sdk.md Outdated Show resolved Hide resolved
docs/developers/sdk.md Outdated Show resolved Hide resolved
docs/developers/sdk.md Outdated Show resolved Hide resolved
docs/developers/sdk.md Outdated Show resolved Hide resolved
docs/developers/sdk.md Outdated Show resolved Hide resolved
druiz0992
druiz0992 previously approved these changes Sep 17, 2021
Copy link
Contributor

@jleebee jleebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few edits : )

docs/developers/sdk.md Outdated Show resolved Hide resolved
docs/developers/sdk.md Outdated Show resolved Hide resolved
@krlosMata krlosMata force-pushed the feature/add-section-derive-bjj branch from 3eb3643 to 7c154b4 Compare September 24, 2021 10:35
@krlosMata krlosMata requested a review from jleebee September 24, 2021 10:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants