Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance by @bb010g #207

Closed
wants to merge 4 commits into from
Closed

Maintenance by @bb010g #207

wants to merge 4 commits into from

Conversation

roberth
Copy link
Member

@roberth roberth commented Jan 16, 2024

Hi @bb010g, I've cherry-picked some of your commits from #183. Is that ok?

I have not included the following commits:

I might have another look at the testing, if you think those changes are useful, but for a first step, here's some of your commits I could merge right away. (And one of mine I guess)

@roberth
Copy link
Member Author

roberth commented Jan 6, 2025

Maybe I just shouldn't have asked, but this is just weird now.
Closing because of conflict. I could rebase again if you like. It's all fine with me.

@roberth roberth closed this Jan 6, 2025
@bb010g
Copy link

bb010g commented Jan 7, 2025

Sorry, don't know why I missed replying to this! Cherry-picking these is absolutely okay. I'll clean up what's still relevant and resubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants