Enable deletion of project, one at a time. Tasks mapped to the project moves to Inbox. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honestly can't really tell the difference...
…ed for the delete project modal
…g nav links to the anchor (direct parent) in case of propagation issues
…deleted is a project
…er modals/ for deletion modals
…. align naming for clarity
…task yes, i know this breaches DRY... but tbh i don't know how to solve the bug in #41. i want to see if this actually fixes it
…ving itself from the localStorage. fixes #41 and its comments, although breaches DRY as modal is rewritten when it could be shared between task and project deletion confirmations
This was
linked to
issues
May 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #28 and #31. although fixes #41, this breaches DRY principle (don't repeat yourself) so i've added a task for future in #4 to resolve this, potentially generating the same modal, with minor differences depending on type. however, this helped make it clearer for me when trying to solve #41