Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Hemi chain ids #1

Merged
merged 3 commits into from
Mar 26, 2024
Merged

feat: Add Hemi chain ids #1

merged 3 commits into from
Mar 26, 2024

Conversation

gndelia
Copy link

@gndelia gndelia commented Mar 26, 2024

This PR adds the chain IDs defined for Hemi Sepolia and Hemi Mainnet as defined in here. Mainnet is not listed as a supported chain yet because that would cause compilation to fail if some structures/addresses are not defined (Which are not).

Some dependencies needed to be fixed because it would otherwise compilation issues when installing the forked version in other repos (As well as some of the ones listed here are actual dependencies, even though they were not listed in package.json, such as @ethersproject/bignumber)

Once merged, this needs to be published into a package so other repos can add their own changes with it as a dependency

@gndelia gndelia requested review from jcvernaleo and gabmontes March 26, 2024 15:12
@gndelia gndelia self-assigned this Mar 26, 2024
Copy link

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@gndelia gndelia force-pushed the add-hemi-chain-ids branch from 4f5deef to 2fca197 Compare March 26, 2024 15:59
@gndelia gndelia force-pushed the add-hemi-chain-ids branch from 2fca197 to f8aceda Compare March 26, 2024 16:02
@gndelia
Copy link
Author

gndelia commented Mar 26, 2024

@jcvernaleo so linting checks fail on this PR. This is because uniswap uses a github action which has limitations to perform annotations on PRs from forked repos.

According to that doc, we can fix that with

You can modify the default permissions granted to the GITHUB_TOKEN by using the permissions key and set the checks scope to write. See GitHub documentation for more.

I don't have access to do so. You can see here

image

that the action found no prettier issues, but can't annotate in the PR that there were no issues. You can either fix that (with your permissions) or we can merge this one (and any incoming PR) with the Lint job failing. I already disabled the autofix as that doesn't work either (we can manually push the PR with code prettified already)

@gndelia gndelia force-pushed the add-hemi-chain-ids branch from 5d0559d to f6396c4 Compare March 26, 2024 20:21
@gndelia gndelia force-pushed the add-hemi-chain-ids branch from f6396c4 to 39c2def Compare March 26, 2024 20:22
@gabmontes gabmontes merged commit 91ff926 into main Mar 26, 2024
3 of 5 checks passed
@gabmontes gabmontes deleted the add-hemi-chain-ids branch March 26, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants