Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fixed on Get Started section on navbar mobile #989

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

alvarengathomas
Copy link
Contributor

Description

Set fixed on Get Started section on navbar mobile

Screenshots

screen-record.mov

Related issue(s)

Closes #499

Checklist

  • Manual testing passed.
  • Automated tests added, or N/A.
  • Documentation updated, or N/A.
  • Environment variables set in CI, or N/A.

gabmontes
gabmontes previously approved these changes Mar 7, 2025
@dvnahuel
Copy link

dvnahuel commented Mar 7, 2025

Hey @alvarengathomas ! can you create an ngrok enviroment so I can test it? thanks!

@dvnahuel
Copy link

dvnahuel commented Mar 7, 2025

The only two minor changes I would suggest would be. cc: @alvarengathomas

  1. Make the background-color of the navbar white
  2. Make the background-color of the CTA container color neutral-50
Screenshot 2025-03-07 at 4 05 38 PM

Copy link
Contributor

@gndelia gndelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation-wise looks good to me, let's just add Nahuel suggestion

@alvarengathomas
Copy link
Contributor Author

@gndelia @dvnahuel

Captura de Tela 2025-03-07 às 16 32 22

done

@alvarengathomas alvarengathomas merged commit 26b5f81 into main Mar 7, 2025
6 checks passed
@alvarengathomas alvarengathomas deleted the fixed-get-started-mobile branch March 7, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Get Started" should be a separated section (and fixed when scrolling) on mobile
4 participants