Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brBTC, Remote Bridged mBTC and Bridged egETH tokens #42

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

gndelia
Copy link
Contributor

@gndelia gndelia commented Mar 3, 2025

Related to hemilabs/ui-monorepo#938
Related to hemilabs/ui-monorepo#752

Note that except for btBTC, these tokens have spaces in the symbol name, which contradicts the schema validation done by Uniswap. See #41

Because of this, I also updated the convention that the icon should be symbol.svg in lowercase, replacing spaces with -

@gndelia gndelia self-assigned this Mar 3, 2025
@gndelia gndelia requested a review from gabmontes as a code owner March 3, 2025 20:11
@gndelia gndelia marked this pull request as draft March 3, 2025 20:27
@gndelia
Copy link
Contributor Author

gndelia commented Mar 3, 2025

Moving to Draft, so I can take advantage of this and add brBTC as well

@gndelia
Copy link
Contributor Author

gndelia commented Mar 3, 2025

Ready to review again!

@gndelia gndelia marked this pull request as ready for review March 3, 2025 20:31
@gndelia gndelia changed the title Add Remote Bridged mBTC and Bridged egETH tokens Add brBTC, Remote Bridged mBTC and Bridged egETH tokens Mar 3, 2025
@gndelia gndelia merged commit 45d0e8c into master Mar 3, 2025
6 checks passed
@gndelia gndelia deleted the add-mbtc-eg-eth branch March 3, 2025 20:49
@gndelia gndelia mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants