Increase max JSON file size for contract verification #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabmontes
requested review from
gndelia,
max-sanchez,
alvarengathomas,
rafappelt and
ArturDolzan
gndelia
approved these changes
Feb 13, 2025
alvarengathomas
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Related Issue(s)
The maximum JSON file size to upload when trying to verify a contract is hardcoded to 20 MBytes. In some cases, this limit is hit and the contracts cannot be verified, as reported by @max-sanchez a few days ago in re the BTC vault contracts.
Proposed Changes
Increase the hardcoded value to 50 MBytes. That should be enough for now.
Additional Information
In the future, this could be configured through an environment variable. Probably the better way to do so is to add the variable in the
configs/appstructure.