rector: add ClassPropertyAssignToConstructorPromotionRector

This rule simplifies the class interface by combining the ctor argument
with the property declaration.

rector.php

@@ -5,6 +5,7 @@
 use Rector\Php70\Rector\StmtsAwareInterface\IfIssetToCoalescingRector;
 use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
 use Rector\Php74\Rector\Assign\NullCoalescingOperatorRector;
+use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector;
 use Rector\Php80\Rector\FuncCall\ClassOnObjectRector;
 use Rector\Php81\Rector\Array_\FirstClassCallableRector;
 use Rector\PHPUnit\Set\PHPUnitSetList;
@@ -17,6 +18,7 @@
 	->withImportNames(true, false)
 	->withRules([
 		ClassOnObjectRector::class,
+		ClassPropertyAssignToConstructorPromotionRector::class,
 		DirNameFileConstantToDirConstantRector::class,
 		FirstClassCallableRector::class,
 		IfIssetToCoalescingRector::class,

src/lib/Smr/AbstractShip.php

@@ -30,8 +30,6 @@ class AbstractShip {
 		RACE_NIJARIN => SHIP_TYPE_REDEEMER,
 	];
 
-	protected AbstractPlayer $player;
-
 	protected int $gameID;
 	protected ShipType $shipType;
 
@@ -51,9 +49,8 @@ class AbstractShip {
 	protected bool $hasChangedCloak = false;
 	protected bool $hasChangedIllusion = false;
 
-	public function __construct(AbstractPlayer $player) {
-		$this->player = $player;
-		$this->gameID = $player->getGameID();
+	public function __construct(protected AbstractPlayer $player) {
+		$this->gameID = $this->player->getGameID();
 		$this->regenerateShipType();
 	}