Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/589 batch normalization #748

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

krajsek
Copy link
Member

@krajsek krajsek commented Mar 18, 2021

Description

Issue/s resolved: #

Changes proposed:

Type of change

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

yes / no

@ghost
Copy link

ghost commented May 12, 2022

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #748 (f93ebcd) into main (43d0a38) will decrease coverage by 0.58%.
Report is 67 commits behind head on main.
The diff coverage is 18.47%.

@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
- Coverage   92.32%   91.74%   -0.58%     
==========================================
  Files          77       78       +1     
  Lines       11056    11144      +88     
==========================================
+ Hits        10207    10224      +17     
- Misses        849      920      +71     
Flag Coverage Δ
unit 91.74% <18.47%> (-0.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
heat/nn/__init__.py 39.02% <11.11%> (-2.65%) ⬇️
heat/nn/batchnorm.py 19.27% <19.27%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ClaudiaComito ClaudiaComito added this to the Repo Clean-Up milestone Jul 31, 2023
@mrfh92 mrfh92 mentioned this pull request Aug 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Thank you for the PR!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants