Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load slices of hdf5 dataset #1753

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

JuanPedroGHM
Copy link
Member

Some users have expressed interest in only loading partial slices from an HDF5 dataset. This PR adds the slices argument to load_hdf5, to allow dataset slicing like in the with the h5py API.

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

Issue/s resolved: #

Changes proposed:

  • Slice argument for load_hdf5
  • Auxiliary function to calculate the new size and offset of a sliced axis
  • Hypothesis and pytest as a dependency for tests
  • Hypothesis tests for the new functionality.

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

@JuanPedroGHM JuanPedroGHM marked this pull request as draft December 16, 2024 16:59
Copy link
Contributor

Thank you for the PR!

@JuanPedroGHM JuanPedroGHM marked this pull request as ready for review December 18, 2024 08:21
Copy link
Contributor

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant