Bugs/1627 bug test vmap fails on multi node runs on hardware accelerators #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! |
|
seems to be even more strange: the GitHub runner also only achieves tol=1e-4 on CPU for the respective test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1738 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 84 84
Lines 12445 12445
=======================================
Hits 11482 11482
Misses 963 963
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
…_runs_on_hardware_accelerators
|
Thank you for the PR! |
1 similar comment
|
Thank you for the PR! |
…_runs_on_hardware_accelerators
mrfh92
added
bug
|
Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due Diligence
benchmarks: created for new functionalitybenchmarks: performance improved or maintaineddocumentation updated where neededDescription
Issue/s resolved: #1627
Changes proposed:
default accuracy in allclose is to high for one test on GPUs and some CPUs
Type of change
decrease accuracy (to tolerance 1e-4, which is still small enough to exclude passing of the test by lucky chance)