Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement polar decomposition #1697

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Implement polar decomposition #1697

wants to merge 35 commits into from

Conversation

mrfh92
Copy link
Collaborator

@mrfh92 mrfh92 commented Oct 28, 2024 •
edited
Loading

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • benchmarks: created for new functionality to discuss: add further benchmarks without having the existing ones refactored? currently not available
    • benchmarks: performance improved or maintained currently not available
    • documentation updated where needed

Description

Issue/s resolved: #

Changes proposed:

see #1696

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

@mrfh92 mrfh92 added ESAPCA relevant for the ESA-funded project "ESAPCA" linalg enhancement New feature or request labels Oct 28, 2024
@mrfh92 mrfh92 marked this pull request as ready for review October 31, 2024 10:04
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.57627% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.36%. Comparing base (443afe3) to head (d308bdf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
heat/core/linalg/pd.py 99.10% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
+ Coverage   92.26%   92.36%   +0.09%     
==========================================
  Files          84       85       +1     
  Lines       12445    12618     +173     
==========================================
+ Hits        11482    11654     +172     
- Misses        963      964       +1
Flag Coverage Δ
unit 92.36% <99.57%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@ClaudiaComito ClaudiaComito added this to the 1.6 milestone Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Nov 15, 2024

batched QR must be merged first #1720

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@mrfh92 mrfh92 mentioned this pull request Nov 18, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Thank you for the PR!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Thank you for the PR!

Hoppe and others added 5 commits December 9, 2024 17:37
QR for split=0 and non tall-skinny data
6430afd
@mrfh92
Merge branch 'main' into features/1736-QR_for_non-tall-skinny_matrice…
7b26be1 
…s_and_split=0
debugging
3a77070
Merge branch 'features/1736-QR_for_non-tall-skinny_matrices_and_split…
b6bd730 
…=0' of github.com:helmholtz-analytics/heat into features/1736-QR_for_non-tall-skinny_matrices_and_split=0
Merge branch 'features/1736-QR_for_non-tall-skinny_matrices_and_split…
3be5913 
…=0' into features/1696-Implement_Polar_Decomposition
@mrfh92
Copy link
Collaborator Author

mrfh92 commented Dec 10, 2024

#1744 needs to be merged first

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@mrfh92 mrfh92 mentioned this pull request Dec 10, 2024
Open
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Dec 10, 2024

btw: to cover the missing line will probably very difficult as one needs to find a matrix such that the (inexact) randomized condition number estimator estimates its condition between 1e5 and 1e7

@mrfh92 mrfh92 self-assigned this Dec 10, 2024
@mrfh92 mrfh92 added the PR talk label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClaudiaComito ClaudiaComito Awaiting requested review from ClaudiaComito

@Hakdag97 Hakdag97 Awaiting requested review from Hakdag97

At least 1 approving review is required to merge this pull request.

Assignees

@mrfh92 mrfh92

Labels
enhancement New feature or request ESAPCA relevant for the ESA-funded project "ESAPCA" linalg PR talk
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
3 participants
@mrfh92 @JuanPedroGHM @ClaudiaComito