Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release drafter update and autolabeler #1681

Merged
merged 11 commits into from
Dec 18, 2024

Conversation

JuanPedroGHM
Copy link
Member

@JuanPedroGHM JuanPedroGHM commented Oct 16, 2024

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

Update to the configuration. This will not work properly on the next release, but as long as we stay on the same release branch, this should be fine. We could stick with our current branching strategy, but every time we create a new release branch, it will cause some trouble.

This also includes some auto-labeling functionality.

Issue/s resolved: #

Changes proposed:

  • Workflow changes to releases drafter

Does this change modify the behaviour of other functions? If so, which?

no

@ClaudiaComito ClaudiaComito self-requested a review December 2, 2024 09:20
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @JuanPedroGHM , I have a few comments / questions

.github/rd-release-config.yml Outdated Show resolved Hide resolved
.github/rd-release-config.yml Outdated Show resolved Hide resolved
.github/workflows/release-prep.yml Outdated Show resolved Hide resolved
.github/workflows/release-prep.yml Outdated Show resolved Hide resolved
.github/rd-release-config.yml Show resolved Hide resolved
.github/rd-release-config.yml Show resolved Hide resolved
.github/rd-release-config.yml Outdated Show resolved Hide resolved
@JuanPedroGHM JuanPedroGHM changed the title Release drafter update attempt #2 Release drafter update and autolabeler Dec 16, 2024
Comment on lines +80 to +85
# Create PR for main
gh pr create --base main \
--head ${{ env.PR_BRANCH }} \
--title "Heat ${{ env.VERSION }} - Main" \
--body "Copy of latest pre-release PR targeting release." \
--label invalid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR be created before release or within the post-release workflow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it could be useful to have it from the start, as it might highlight merge conflicts and CI errors at the same time in both target branches at the same time, so we would find the earlier.

We could ignore until after the release PR is merged, or move this to a post-release workflow

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, let's try it out

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work @JuanPedroGHM !

@JuanPedroGHM JuanPedroGHM merged commit 89bcf8d into main Dec 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants