-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release drafter update and autolabeler #1681
Release drafter update and autolabeler #1681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @JuanPedroGHM , I have a few comments / questions
Co-authored-by: Claudia Comito <[email protected]>
Co-authored-by: Claudia Comito <[email protected]>
# Create PR for main | ||
gh pr create --base main \ | ||
--head ${{ env.PR_BRANCH }} \ | ||
--title "Heat ${{ env.VERSION }} - Main" \ | ||
--body "Copy of latest pre-release PR targeting release." \ | ||
--label invalid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this PR be created before release or within the post-release workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it could be useful to have it from the start, as it might highlight merge conflicts and CI errors at the same time in both target branches at the same time, so we would find the earlier.
We could ignore until after the release PR is merged, or move this to a post-release workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, let's try it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work @JuanPedroGHM !
Due Diligence
Description
Update to the configuration. This will not work properly on the next release, but as long as we stay on the same release branch, this should be fine. We could stick with our current branching strategy, but every time we create a new release branch, it will cause some trouble.
This also includes some auto-labeling functionality.
Issue/s resolved: #
Changes proposed:
Does this change modify the behaviour of other functions? If so, which?
no