Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/HPC-tutorial via python script #1527

Merged
merged 25 commits into from
Dec 16, 2024
Merged

Features/HPC-tutorial via python script #1527

merged 25 commits into from
Dec 16, 2024

Conversation

mrfh92
Copy link
Collaborator

@mrfh92 mrfh92 commented Jun 10, 2024 •
edited by ClaudiaComito
Loading

A version of our Tutorials in "classical" HPC-style, i.e. with Python scripts instead of notebooks, is added.
Issue/s resolved: #1523

@mrfh92 mrfh92 linked an issue Jun 10, 2024 that may be closed by this pull request
Add HPC tutorials for HAICON #1523
Closed
ClaudiaComito
ClaudiaComito requested changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some changes to make precommit happy

tutorials/hpc/01_basics/05_basics_broadcast.py Outdated Show resolved Hide resolved
tutorials/hpc/02_loading_preprocessing/02_preprocessing.py Outdated Show resolved Hide resolved
ClaudiaComito
ClaudiaComito previously approved these changes Jun 10, 2024
View reviewed changes
@ClaudiaComito ClaudiaComito added the documentation Anything related to documentation label Jun 11, 2024
@ClaudiaComito ClaudiaComito added this to the 1.5.0 milestone Jun 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Aug 12, 2024
@ClaudiaComito
Copy link
Contributor

Can this be merged or was something missing @mrfh92 ?

@github-actions github-actions bot removed the stale label Aug 26, 2024
@mrfh92
Copy link
Collaborator Author

mrfh92 commented Aug 26, 2024

As discussed this morning, a few last changes will be necessary.

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Aug 29, 2024

@ClaudiaComito I have done my changes. Now it's fine from my point of view.
I have added two example slurm scripts and a readme with hints how to use them.

@mrfh92 mrfh92 requested a review from ClaudiaComito August 29, 2024 11:06
@mrfh92 mrfh92 added the PR talk label Sep 1, 2024
@mrfh92
Copy link
Collaborator Author

mrfh92 commented Sep 2, 2024

todos: code formatting by black might look strange here

@mrfh92 mrfh92 removed the PR talk label Sep 2, 2024
@ClaudiaComito ClaudiaComito modified the milestones: 1.5.0, 1.6 Sep 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This pull request is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Dec 2, 2024
@github-actions github-actions bot removed the stale label Dec 9, 2024
ClaudiaComito
ClaudiaComito reviewed Dec 12, 2024
View reviewed changes
tutorials/hpc/01_basics/01_basics_dndarrays.py Outdated
Comment on lines 15 to 20
a = ht.ones(
(
4,
5,
)
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrfh92 I just noticed you already excluded the tutorials directory from the linting on this branch. It works locally but we need to merge the change into main first, see #1748 , otherwise pre-commit on remote will still reformat.

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Dec 16, 2024

@ClaudiaComito I have done the reformatting

@github-actions GitHub Actions
Copy link
Contributor

Thank you for the PR!

@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.25%. Comparing base (8e8c37d) to head (b1ef85d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1527   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files          84       84           
  Lines       12445    12445           
=======================================
  Hits        11481    11481           
  Misses        964      964
Flag Coverage Δ
unit 92.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ClaudiaComito
ClaudiaComito approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @mrfh92 thanks a lot!

@ClaudiaComito ClaudiaComito merged commit 4628cb5 into main Dec 16, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClaudiaComito ClaudiaComito ClaudiaComito approved these changes

Assignees
No one assigned
Labels
documentation Anything related to documentation
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

Add HPC tutorials for HAICON
2 participants
@mrfh92 @ClaudiaComito