Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed factories.array to DNDarray #1323

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Reisii
Copy link
Collaborator

@Reisii Reisii commented Jan 15, 2024

Due Diligence

  • General:
    • base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

Issue/s resolved: #

Changes proposed:

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

@ghost
Copy link

ghost commented Jan 15, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

mrfh92 and others added 10 commits January 22, 2024 13:18
…_array_with_DNDarray_construct_where_possible
…_DNDarray_construct_where_possible' of github.com:helmholtz-analytics/heat into features/818-Module_linalg_replace_factories_array_with_DNDarray_construct_where_possible
…_array_with_DNDarray_construct_where_possible
…_DNDarray_construct_where_possible' of github.com:helmholtz-analytics/heat into features/818-Module_linalg_replace_factories_array_with_DNDarray_construct_where_possible
Copy link
Contributor

Thank you for the PR!

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3655bd2) 91.76% compared to head (da4ba43) 91.81%.

❗ Current head da4ba43 differs from pull request most recent head 257cdae. Consider uploading reports for the commit 257cdae to get more accurate results

Files Patch % Lines
heat/core/linalg/qr.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1323      +/-   ##
==========================================
+ Coverage   91.76%   91.81%   +0.05%     
==========================================
  Files          79       79              
  Lines       11508    11465      -43     
==========================================
- Hits        10560    10527      -33     
+ Misses        948      938      -10     
Flag Coverage Δ
unit 91.81% <83.33%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…_array_with_DNDarray_construct_where_possible
@mrfh92 mrfh92 marked this pull request as ready for review February 22, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants