Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs/1258 bug lasso does not work on gpu #1269

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

mrfh92
Copy link
Collaborator

@mrfh92 mrfh92 commented Nov 22, 2023

Bug fix has been merged in release/1.3.x only so far.

Hoppe and others added 3 commits November 7, 2023 16:21
* upgrade checkout action & use default token

* increase tolerance for single-prec torch.inv comparison

* fix typo

---------

Co-authored-by: Claudia Comito <[email protected]>
@ghost
Copy link

ghost commented Nov 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@mrfh92 mrfh92 marked this pull request as ready for review November 22, 2023 08:54
Copy link
Contributor

Thank you for the PR!

@mrfh92 mrfh92 closed this Nov 22, 2023
Copy link
Contributor

Thank you for the PR!

@mrfh92 mrfh92 reopened this Nov 22, 2023
Copy link
Contributor

Thank you for the PR!

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e4211d) 91.83% compared to head (ecadc79) 91.83%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1269   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files          77       77           
  Lines       11191    11191           
=======================================
  Hits        10277    10277           
  Misses        914      914           
Flag Coverage Δ
unit 91.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrfh92 !

@ClaudiaComito ClaudiaComito merged commit 5125ccc into main Nov 22, 2023
48 checks passed
@mtar mtar deleted the bugs/1258-_Bug_Lasso_does_not_work_on_GPU branch February 28, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants