Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge latest release/1.3.x changes and upgrade version in main #1268

Merged
merged 7 commits into from
Nov 22, 2023

Conversation

ClaudiaComito
Copy link
Contributor

@ClaudiaComito ClaudiaComito commented Nov 22, 2023

Due Diligence

  • General:
    • base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

Merging CI matrix fix #1267, PyTorch workflow fix #1264 , and updating version to 1.4.0-dev

Issue/s resolved: CI matrix stuck for days among other things

Changes proposed:

Type of change

NA

Memory requirements

NA

Performance

NA

Does this change modify the behaviour of other functions? If so, which?

no

@ghost
Copy link

ghost commented Nov 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@ClaudiaComito ClaudiaComito added workflows CI continuous integration labels Nov 22, 2023
@ClaudiaComito ClaudiaComito requested review from mtar and mrfh92 November 22, 2023 05:19
Copy link
Contributor

Thank you for the PR!

1 similar comment
Copy link
Contributor

Thank you for the PR!

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1263887) 91.83% compared to head (0e4211d) 91.83%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1268   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files          77       77           
  Lines       11191    11191           
=======================================
  Hits        10277    10277           
  Misses        914      914           
Flag Coverage Δ
unit 91.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@mrfh92 mrfh92 merged commit 29213dc into main Nov 22, 2023
43 checks passed
@mrfh92 mrfh92 deleted the workflows/merge-release-changes-into-main branch November 22, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants