Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync pre-commit configuration with main branch #1266

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

ClaudiaComito
Copy link
Contributor

@ClaudiaComito ClaudiaComito commented Nov 22, 2023

Due Diligence

  • General:
    • base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

.pre-commit-config.yaml updates are automated on the main branch, the corresponding file on release/1.3.x has diverged. Bringing it to the latest version.

Issue/s resolved: #

Changes proposed:

  • pull current .pre-commit-config.yaml from main

Type of change

NA

Memory requirements

NA

Performance

NA

Does this change modify the behaviour of other functions? If so, which?

no

@ghost
Copy link

ghost commented Nov 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

Thank you for the PR!

@ClaudiaComito ClaudiaComito added this to the 1.3.1 milestone Nov 22, 2023
Copy link
Collaborator

@mrfh92 mrfh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from my point of view.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (754fe1d) 92.17% compared to head (e23d9d7) 92.17%.
Report is 9 commits behind head on release/1.3.x.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/1.3.x    #1266   +/-   ##
==============================================
  Coverage          92.17%   92.17%           
==============================================
  Files                 75       75           
  Lines              10703    10703           
==============================================
  Hits                9865     9865           
  Misses               838      838           
Flag Coverage Δ
unit 92.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrfh92 mrfh92 merged commit f1e0894 into release/1.3.x Nov 22, 2023
42 checks passed
@mrfh92 mrfh92 deleted the workflows/update-pre-commit-config branch November 22, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants